fix: post-merge P2 findings — EINTR-safe threadSleep, runtime.deinit ownership#126
Open
fix: post-merge P2 findings — EINTR-safe threadSleep, runtime.deinit ownership#126
Conversation
- compat.threadSleep: nanosleep now loops across EINTR, consuming the remaining duration from the kernel's out-param. Previously a single signal could collapse a multi-second backoff to near-zero, driving unnecessary wakeups in WAL / background workers under signal-heavy conditions. - runtime: track owns_threaded so deinit() only tears down threaded when init() actually constructed it. setIo()/ensureForTest() publish an externally-owned Io (process.Init's, or global_single_threaded), and calling threaded.deinit() on undefined state there would be UB. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #125. Two P2 issues the Codex reviewer flagged after merge.
compat.threadSleep:nanosleepnow loops past EINTR, consuming the remaining-time out-param. A single signal could previously collapse a multi-second backoff to near-zero — WAL and background workers rely on the full duration for throttling.runtime.deinit: newowns_threadedflag;deinit()only callsthreaded.deinit()wheninit()actually constructed it.setIo()andensureForTest()publish externally-owned Io, and tearing downthreadedon undefined state would be UB.Test plan
zig buildclean (macOS)🤖 Generated with Claude Code