Replace vertexai dependency with google-genai #11
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the plugin from the legacy google-cloud-aiplatform (vertexai) SDK to the newer google-genai SDK for Google Cloud Vertex AI integration. This is a major version bump to 0.3.0.
- Replaced vertexai SDK with google-genai SDK (version >=1.48.0)
- Updated client initialization and API usage to new SDK patterns
- Updated Python version requirement from >3.8 to >=3.10
- Reordered model list and added new models (gemini-2.5-flash-lite)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| llm_vertex.py | Migrated from vertexai SDK to google-genai SDK, updated client initialization and message handling APIs |
| pyproject.toml | Updated dependencies to google-genai>=1.48.0, bumped version to 0.3.0, and changed Python requirement to >=3.10 |
| tests/test_llm_vertex.py | Updated mocked modules to match new google-genai SDK structure |
| .github/workflows/test.yml | Removed Python 3.9 from test matrix and fixed YAML indentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| requires-python = ">3.8" | ||
| authors = [{ name = "Justyn Shull" }] | ||
| license = { text = "Apache-2.0" } | ||
| classifiers = ["License :: OSI Approved :: Apache Software License"] |
There was a problem hiding this comment.
The Python version constraint was changed from >3.8 to >=3.10. This is a breaking change that drops support for Python 3.8 and 3.9, which should be documented in the release notes or changelog to inform users.
| classifiers = ["License :: OSI Approved :: Apache Software License"] | |
| classifiers = ["License :: OSI Approved :: Apache Software License"] | |
| # Breaking change: Dropped support for Python 3.8 and 3.9. Minimum required Python version is now 3.10. |
| if not conversation: | ||
| return [] | ||
| messages = [] | ||
| print(f"Build_history conversation: {conversation}") |
There was a problem hiding this comment.
Debug print statement should be removed or replaced with proper logging. This will clutter production output and expose internal conversation data unnecessarily.
| chat = self.client.chats.create( | ||
| model=self.model_name, | ||
| config=config, | ||
| history=history if history else None |
There was a problem hiding this comment.
The conditional history if history else None is redundant since build_history already returns an empty list when there's no conversation. Either pass history directly or update the API call to handle empty lists appropriately.
| history=history if history else None | |
| history=history |
|
I added it in my fork some time ago. https://github.com/avoidik/llm-vertex |
See https://cloud.google.com/vertex-ai/generative-ai/docs/deprecations/genai-vertexai-sdk
Fixes #10