Skip to content

Comments

Configurable rate limit backend#12

Draft
fishtreesugar wants to merge 1 commit intojvoegele:masterfrom
fishtreesugar:rate-limit-backends
Draft

Configurable rate limit backend#12
fishtreesugar wants to merge 1 commit intojvoegele:masterfrom
fishtreesugar:rate-limit-backends

Conversation

@fishtreesugar
Copy link

is it a good idea?

@a3kov
Copy link

a3kov commented Apr 6, 2023

I would just replace ex_rated with Hammer completely, as the latter supersedes it and has pluggable backends itself. To have a pluggable backend which itself has pluggable backends looks like an anti-pattern (a knob on a knob)

@jvoegele
Copy link
Owner

I'll have a look at hammer and see if it might be a good replacement for ex_rated. At first glance I worry that using hammer would require the user to configure it in their app configuration, and I would prefer not to place that burden on the user. But I haven't looked into it very deeply yet, so I could be mistaken.

In any case, I wouldn't mind getting rid of the dependency on ex_rated and either use hammer (if it's a good fit) or possibly just roll my own rate-limiting implementation into external_service.

@GiovanniHessel94
Copy link

@jvoegele first of all thanks for this great library!

Is there any news on adding support to Hammer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants