You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would just replace ex_rated with Hammer completely, as the latter supersedes it and has pluggable backends itself. To have a pluggable backend which itself has pluggable backends looks like an anti-pattern (a knob on a knob)
I'll have a look at hammer and see if it might be a good replacement for ex_rated. At first glance I worry that using hammer would require the user to configure it in their app configuration, and I would prefer not to place that burden on the user. But I haven't looked into it very deeply yet, so I could be mistaken.
In any case, I wouldn't mind getting rid of the dependency on ex_rated and either use hammer (if it's a good fit) or possibly just roll my own rate-limiting implementation into external_service.
@jvoegele first of all thanks for this great library!
Is there any news on adding support to Hammer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is it a good idea?