feat: room members list sidebar#50
Merged
Merged
Conversation
… input from rendering on non-room routes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+44
to
+45
| function createMembersList(members: RoomMember[]) { | ||
| members.sort((a, b) => { |
There was a problem hiding this comment.
createMembersList calls members.sort() which mutates the array in-place. The array passed here is the same reference stored in useRoomMembers's members shallowRef, so after this call the upstream reactive state is silently reordered. Since shallowRef only tracks reference changes, this mutation is invisible to Vue's reactivity system and could confuse any other consumer of that ref. Sorting a copy avoids the side-effect.
Suggested change
| function createMembersList(members: RoomMember[]) { | |
| members.sort((a, b) => { | |
| function createMembersList(members: RoomMember[]) { | |
| const sorted = [...members] | |
| sorted.sort((a, b) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.