Add support for Windows #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add datalink_type_t enum to distinguish between Ethernet and raw IP packets - Implement auto-detection of datalink type from packet structure - Add *_ex() variants of filter functions with explicit datalink parameter - Refactor filter creation to use dynamic offset calculation - Support both Ethernet frames (Linux/BSD) and raw IP (Windows) formats - Fix protocol and port filtering for Windows raw socket packets This enables babysniff to work correctly on Windows where raw sockets provide packets without Ethernet headers, while maintaining compatibility with existing Linux/BSD Ethernet-based packet capture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Windows support, hopefully without breaking anything!
TL;DR
Long story
The Windows implementation uses a raw socket and includes proper privilege handling for raw socket access.
I created abstraction layers for the main platform differences (networking headers, time functions, string operations, etc) so the core logic stays clean.
The BPF filters now automatically adjust when they're dealing with Ethernet frames (Linux and BSD) or raw IP packets (Windows). This was the trickiest part since Windows raw sockets work differently.
I also added CMake configs for Visual Studio and MinGW, besides the documentation for building on Windows.
The filters work seamlessly, with the exception of Layer 2 protocols that don't work on Windows without an extra driver, which we're not writing at the moment.
It still has 0 external dependencies!
This PR closes #7.