Add a case to ob-gptel--make-callback to ignore reasoning and tool calls#14
Open
bramboomen wants to merge 1 commit into
Open
Add a case to ob-gptel--make-callback to ignore reasoning and tool calls#14bramboomen wants to merge 1 commit into
bramboomen wants to merge 1 commit into
Conversation
Currently any other response from gptel than a string or 'abort is treated as an error. This results in an error if an LLM performs a tool call or returns its reasoning. In these cases gtpel-request will return a cons cell like (reasoning . text), (tool-call . (...)) or (tool-result . (...)). These get captured by the default route of cond resulting in an error but no error message. This change only outputs an error if the response is nil, thereby ignoring any reasoning or tool call responses.
|
Flipped elpaca over to your repo and branch for this PR and it worked. Ty for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any other response from gptel than a string or 'abort is treated as an error. This results in an error if an LLM performs a tool call or returns its reasoning. In these cases gtpel-request will return a cons cell like (reasoning . text), (tool-call . (...)) or (tool-result . (...)). These get captured by the default route of cond resulting in an error but no error message.
This change only outputs an error if the response is nil, thereby ignoring any reasoning or tool call responses.
This likely solves the error reported by #13