fix: cast-aware reconfigure to preserve Chromecast session#221
Open
fix: cast-aware reconfigure to preserve Chromecast session#221
Conversation
…fig changes When casting, use loadPlaylist instead of configurePlayer to avoid tearing down the SDK's CastProvider. Also fixes podspec flag accumulation, setUpCastController crash, and isCasting tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recreatePlayerWithConfigwas callingconfigurePlayerwhich reinitializes the player and tears down the SDK's internal CastProvider, killing the cast session.loadPlaylistinstead ofconfigurePlayerwhen actively casting, preserving the cast session while loading new content.USE_GOOGLE_CASTwas silently dropped when both Cast and IMA were enabled.setUpCastControllercrash (playerView.player as! Bool) and adds support forplayerViewController.isCastingstate in cast delegate callbacks.Blocked on native SDK change
This PR is awaiting a native iOS SDK (JWPlayerKit) update to expose a public method for parsing Delivery API JSON into
JWPlayerItemobjects. Once available, the RN wrapper can use it to properly parse playlist items during casting, ensuring DRM sources/credentials are correctly forwarded to the cast receiver.Non-DRM casting works as expected with the current changes.
Test plan