Enable JwtParser empty nested algorithm collections. #1007
Merged
+175
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowed the JwtParser to have empty nested algorithm collections, effectively disabling the parser's associated feature: - Clearing the zip() nested collection means parser decompression is disabled - Clearing the sig() nested collection means parser signature verification is disabled (i.e. all JWSs will be unsupported/rejected) - Clearing the enc() or key() nested collections means parser decryption is disabled (i.e. all JWEs will be unsupported/rejected)
Allowed the JwtParser to have empty nested algorithm collections, effectively disabling the parser's associated feature: - Clearing the zip() nested collection means parser decompression is disabled - Clearing the sig() nested collection means parser signature verification is disabled (i.e. all JWSs will be unsupported/rejected) - Clearing the enc() or key() nested collections means parser decryption is disabled (i.e. all JWEs will be unsupported/rejected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #996.
Allowed the
JwtParserto have empty nested algorithm collections, effectively disabling the parser's associated feature:zip()nested collection means parser decompression is disabledsig()nested collection means parser signature verification is disabled (i.e. all JWSs will be unsupported/rejected)enc()orkey()nested collections means parser decryption is disabled (i.e. all JWEs will be unsupported/rejected)