Skip to content

fix(installer): refuse symlinked destinations - #17

Open
morluto wants to merge 1 commit into
jxnl:masterfrom
morluto:fix/refuse-symlink-destinations
Open

fix(installer): refuse symlinked destinations#17
morluto wants to merge 1 commit into
jxnl:masterfrom
morluto:fix/refuse-symlink-destinations

Conversation

@morluto

@morluto morluto commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • refuse destination paths that contain symbolic links before creating directories, copying files, or creating backups
  • preflight every recursively copied destination so nested file and directory links cannot redirect writes
  • add regression coverage for a symlinked Codex skills root and an existing prompt-file symlink

The installer now fails with a clear error instead of following the link. This intentionally treats symlink-managed destinations as unsupported rather than guessing whether a link is expected.

Validation

  • confirmed the new regression test fails on 34d197b because the skills install writes through the link
  • bash -n install.sh tests/test_symlink_destinations.sh
  • bash tests/test_symlink_destinations.sh
  • ./tests/run.sh
  • independent exact-diff review: no actionable findings

Closes #16

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer can write outside the target through symlinked destinations

1 participant