Fix basal pump units and Gym action-space limits - #99
Open
LI-Jialu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
pump_params.csv stores basal increments and limits in U/hour, while controller actions and the patient model use U/min. The previous implementation multiplied basal rates by the U-to-pmol conversion constant before applying the pump parameters, so realistic rates were effectively not quantized and the Gym upper bound was exposed as 30 U/min instead of 30 U/hour.
This addresses the basal/action-space portion of #71. Bolus behavior is intentionally unchanged because its interval/amount API semantics require a separate compatibility discussion. Patient equations, meals, rewards, and termination thresholds are unchanged.
Behavior impact
Testing
Ran the full unittest suite: 20 tests passed in 302.845 seconds.