Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ostests coredns check timeout #5430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juanluisvaladas
Copy link
Contributor

Description

Fixes terraform apply on ubuntu 22.04 and alpine 3.20

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fixes terraform apply on ubuntu 22.04 and alpine 3.20

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
@twz123
Copy link
Member

twz123 commented Jan 13, 2025

@juanluisvaladas
Copy link
Contributor Author

Very odd that it doesn't solve it for ubuntu 22.04, it fix it when I launch it myself with apparently the same configuration.

Using the same versions of everything. Anyway it does fix it for alpine 3.20 so I think it's worth merging.

@twz123
Copy link
Member

twz123 commented Jan 14, 2025

Do we know why this has regressed and needs longer than before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants