Wait for autpoilot CRDs before starting Autopilot worker component #5497
+172
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wieczorek <[email protected]>
Instead of having multiple brute-force retry loops in a row, just have one that actually watches the CRDs and waits until it has observed all the Autopilot CRDs to be established. This covers API server reachability and CRD availability in one go. It also ensures that controller-runtime registration is done only once. Since controller-runtime v0.19.0, registering the same thing twice will result in an error. Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
wait-for-ap-crds
branch
from
7e098a7 to
f0293f9
Compare
twz123
changed the title
|
This pull request has merge conflicts that need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having multiple brute-force retry loops in a row, just have one that actually watches the CRDs and waits until it has observed all the Autopilot CRDs to be established. This covers API server reachability and CRD availability in one go.
It also ensures that controller-runtime registration is done only once. Since controller-runtime v0.19.0, registering the same thing twice will result in an error.
Type of change
How Has This Been Tested?
Checklist: