[Backport release-1.31] Always skip controller-runtime name validation #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some debug logs whenever running the worker failed. This helps when troubleshooting issues. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit c3cf50a) (cherry picked from commit 87f65b2)
It's not necessary to have two successive retry loops. In fact, it's counterproductive because indexers can only be registered with a manager once. A second attempt will result in an index conflict error. However, this is not a problem if the manager is created in the same retry loop. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit fb08b11) (cherry picked from commit 5ec4a78)
Controller-runtime maintains a global checklist of controller names and does not currently provide a way to unregister the controller names used by discarded managers. The autopilot controller and worker components accidentally share some controller names. So it's necessary to suppress the global name check because the order in which components are started is not fully guaranteed for k0s controller nodes running an embedded worker. Fixes: 79b9596 ("Bump Kubernetes to v1.31.0") Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 2eb6c63) (cherry picked from commit 0f459cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.31:See: