Dedupe initLogging and initSilentLogging - #1153
Open
magic-peach wants to merge 1 commit into
Open
Conversation
Both functions set up the logger identically apart from the default screen log level, per the TODO left on initSilentLogging. Extract the shared body into initLoggingWithDefaultLevel and have both call it with their respective default level; behavior for each caller is unchanged. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two were near-identical (an existing TODO comment flagged it). Extracted the shared body into
initLoggingWithDefaultLevel(ctx, defaultLevel); both are now thin wrappers passing their respective default level. No behavior change.