update onnxruntime package name and hash for riscv64-spacemit by alex-spacemit · Pull Request #3481 · k2-fsa/sherpa-onnx

alex-spacemit · 2026-04-08T06:56:04Z

Summary by CodeRabbit

Documentation
- Added SpacemiT-K1 and SpacemiT-K3 to supported platforms list
Chores
- Updated SpacemiT ONNX Runtime package to version 2.0.2+rc1
- Updated test workflow configurations for SpacemiT platform

coderabbitai · 2026-04-08T06:56:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 96aeecd2-6dbc-49c0-a5f6-67c6f81cdc5a

📥 Commits

Reviewing files that changed from the base of the PR and between 625f63a and 40b0792.

📒 Files selected for processing (3)

.github/workflows/riscv64-spacemit-linux.yaml
README.md
cmake/onnxruntime-linux-riscv64-spacemit.cmake

💤 Files with no reviewable changes (1)

.github/workflows/riscv64-spacemit-linux.yaml

📝 Walkthrough

Walkthrough

Removes op type filtering from SpacemiT CI workflow steps, adds documentation for SpacemiT NPU platforms (K1 and K3), and updates Spacemit ONNX Runtime package to version 2.0.2+rc1 with corresponding hash verification.

Changes

Cohort / File(s)	Summary
CI Workflow `.github/workflows/riscv64-spacemit-linux.yaml`	Removed environment variable setup (`SPACEMIT_EP_DISABLE_OP_TYPE_FILTER`) and status message output from streaming speech recognition and offline TTS test steps.
Documentation `README.md`	Added SpacemiT-K1 and SpacemiT-K3 NPU platforms to the "Supported platforms" list with corresponding markdown link references.
Build Configuration `cmake/onnxruntime-linux-riscv64-spacemit.cmake`	Updated Spacemit ONNX Runtime package version from `2.0.1` to `2.0.2+rc1` and refreshed corresponding SHA256 hash for archive verification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

add spacemit ort ep for spacemit riscv cpus #2837: Updates Spacemit ONNX Runtime package version and CI integration, directly related to the CMake and workflow configuration changes in this PR.
Update README to include NPU support #2830: Adds NPU platform support documentation to README, closely aligned with the documentation additions in this PR.

Suggested labels

size:S

Suggested reviewers

csukuangfj

Poem

🐰 A spacemit update hops our way,
K1 and K3 NPUs saved the day!
No ops to filter, versions bump clean,
The smoothest CI you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating the ONNX Runtime package name and hash in the CMake configuration file for riscv64-spacemit.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

csukuangfj

Thank you for your contribution!

gemini-code-assist

Code Review

This pull request updates the onnxruntime package version for SpacemiT RISC-V platforms to 2.0.2+rc1 and updates the corresponding SHA256 hash. It also updates the README.md to include SpacemiT-K1 and SpacemiT-K3 as supported platforms with relevant documentation links. I have no feedback to provide.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the SpacemiT RISC-V64 ONNX Runtime artifact reference and cleans up related CI/runtime documentation to reflect current platform support.

Changes:

Bumped the SpacemiT riscv64 onnxruntime tarball name and updated its SHA256 hash.
Added SpacemiT-K1 and SpacemiT-K3 to the README platform list with reference links.
Removed the temporary CI workaround that disabled specific ops in the SpacemiT EP.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
cmake/onnxruntime-linux-riscv64-spacemit.cmake	Points downloads to the new onnxruntime tarball and updates checksum accordingly.
README.md	Documents additional SpacemiT hardware targets and adds their reference links.
.github/workflows/riscv64-spacemit-linux.yaml	Drops the prior EP op-disable workaround from the riscv64-spacemit CI job steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T07:02:57Z


-set(onnxruntime_pkg_name "spacemit-ort.riscv64.2.0.1.tar.gz")
+set(onnxruntime_pkg_name "spacemit-ort.riscv64.2.0.2+rc1.tar.gz")
 set(onnxruntime_URL  "https://archive.spacemit.com/spacemit-ai/onnxruntime/${onnxruntime_pkg_name}")


+ in the tarball filename can be mishandled by some URL/HTTP tooling (it is sometimes decoded as a space by non-compliant components). To make downloads more robust, consider either (a) URL-encoding the + in the URL (use %2B in the computed download URL) or (b) publishing/using an equivalent filename without + (e.g., -rc1) and referencing that instead.

Suggested change

set(onnxruntime_URL "https://archive.spacemit.com/spacemit-ai/onnxruntime/${onnxruntime_pkg_name}")

string(REPLACE "+" "%2B" onnxruntime_pkg_name_url "${onnxruntime_pkg_name}")

set(onnxruntime_URL "https://archive.spacemit.com/spacemit-ai/onnxruntime/${onnxruntime_pkg_name_url}")

Copilot · 2026-04-08T07:02:58Z

+  - [SpacemiT-K1][SpacemiT-K1]
+  - [SpacemiT-K3][SpacemiT-K3]


The README uses SpacemiT casing here, while the rest of the repo (e.g., filenames like riscv64-spacemit) uses spacemit. It’d be clearer to standardize casing across documentation and build/CI terminology (either adopt the brand casing everywhere in docs or use the repo’s existing Spacemit/Spacemit convention consistently).

Suggested change

- [SpacemiT-K1][SpacemiT-K1]

- [SpacemiT-K3][SpacemiT-K3]

- [Spacemit-K1][SpacemiT-K1]

- [Spacemit-K3][SpacemiT-K3]

Copilot · 2026-04-08T07:02:58Z

+[SpacemiT-K1]: https://cdn-resource.spacemit.com/file/chip/K1/K1_brief_zh.pdf
+[SpacemiT-K3]: https://cdn-resource.spacemit.com/file/chip/K3/K3_brief_zh.pdf


The README uses SpacemiT casing here, while the rest of the repo (e.g., filenames like riscv64-spacemit) uses spacemit. It’d be clearer to standardize casing across documentation and build/CI terminology (either adopt the brand casing everywhere in docs or use the repo’s existing Spacemit/Spacemit convention consistently).

Suggested change

[SpacemiT-K1]: https://cdn-resource.spacemit.com/file/chip/K1/K1_brief_zh.pdf

[SpacemiT-K3]: https://cdn-resource.spacemit.com/file/chip/K3/K3_brief_zh.pdf

[Spacemit-K1]: https://cdn-resource.spacemit.com/file/chip/K1/K1_brief_zh.pdf

[Spacemit-K3]: https://cdn-resource.spacemit.com/file/chip/K3/K3_brief_zh.pdf

Copilot · 2026-04-08T07:02:59Z

          export QEMU_LD_PREFIX=$GITHUB_WORKSPACE/toolchain/sysroot
          export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/toolchain/sysroot/lib
          export QEMU_ARGS="-cpu max,vlen=256,elen=64,vext_spec=v1.0"


This removes the previously documented workaround (SPACEMIT_EP_DISABLE_OP_TYPE_FILTER) without leaving any trace of why it’s no longer needed. To reduce future churn when regressions happen, consider adding a brief comment tying the removal to the onnxruntime/EP version bump (e.g., “fixed in spacemit-ort 2.0.2+rc1”), or keep an opt-in toggle (only set the env var when a workflow input/variable indicates it) so the workaround can be re-enabled quickly if needed.

Copilot · 2026-04-08T07:02:59Z

          export QEMU_LD_PREFIX=$GITHUB_WORKSPACE/toolchain/sysroot
          export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/toolchain/sysroot/lib
          export QEMU_ARGS="-cpu max,vlen=256,elen=64,vext_spec=v1.0"


This removes the previously documented workaround (SPACEMIT_EP_DISABLE_OP_TYPE_FILTER) without leaving any trace of why it’s no longer needed. To reduce future churn when regressions happen, consider adding a brief comment tying the removal to the onnxruntime/EP version bump (e.g., “fixed in spacemit-ort 2.0.2+rc1”), or keep an opt-in toggle (only set the env var when a workflow input/variable indicates it) so the workaround can be re-enabled quickly if needed.

csukuangfj · 2026-04-08T07:29:40Z

Can you have a look at https://github.com/k2-fsa/sherpa-onnx/actions/runs/24122441292/job/70382142458#step:11:850

csukuangfj · 2026-04-08T07:38:33Z

https://archive.spacemit.com/spacemit-ai/onnxruntime/spacemit-ort.riscv64.2.0.2+rc1.tar.gz

Please re-check the above link. If you click, it shows the following

alex-spacemit · 2026-04-08T07:41:14Z

There may be a delay in file synchronization. I'll check it.

alex-spacemit added 2 commits April 8, 2026 14:46

fix: update onnxruntime package name and hash for riscv64-spacemit

9e30ece

feat: add support for SpacemiT-K1 and SpacemiT-K3 platforms in README

40b0792

Copilot AI review requested due to automatic review settings April 8, 2026 06:56

dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 8, 2026

csukuangfj approved these changes Apr 8, 2026

View reviewed changes

csukuangfj merged commit 27c8da5 into k2-fsa:master Apr 8, 2026
2 of 28 checks passed

gemini-code-assist Bot reviewed Apr 8, 2026

View reviewed changes

Copilot AI reviewed Apr 8, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Apr 8, 2026

Fix package name format for ort url #3489

Merged

This was referenced May 6, 2026

Fix x64 gpu onnxruntime url #3578

Merged

build(cmake): update onnxruntime package details for spacemit #3610

Merged

	set(onnxruntime_URL "https://archive.spacemit.com/spacemit-ai/onnxruntime/${onnxruntime_pkg_name}")
	string(REPLACE "+" "%2B" onnxruntime_pkg_name_url "${onnxruntime_pkg_name}")
	set(onnxruntime_URL "https://archive.spacemit.com/spacemit-ai/onnxruntime/${onnxruntime_pkg_name_url}")

		[SpacemiT-K1]: https://cdn-resource.spacemit.com/file/chip/K1/K1_brief_zh.pdf
		[SpacemiT-K3]: https://cdn-resource.spacemit.com/file/chip/K3/K3_brief_zh.pdf

Uh oh!

Conversation

alex-spacemit commented Apr 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

csukuangfj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

csukuangfj commented Apr 8, 2026

Uh oh!

csukuangfj commented Apr 8, 2026

Uh oh!

alex-spacemit commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alex-spacemit commented Apr 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading