Release v1.13.1#3590
Merged
Merged
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (81)
📝 WalkthroughWalkthroughThis PR performs a coordinated version bump across the entire sherpa-onnx repository from version 1.13.0 to 1.13.1. Changes span build configuration (CMakeLists, version.cc), Android/iOS/HarmonyOS app versions, Rust/Python/Node.js package manifests, example applications, and documentation. ChangesVersion 1.13.1 Release Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 1.13.0 to 1.13.1 across various build configurations, dependency manifests, and documentation for Android, iOS, HarmonyOS, Rust, Python, and Node.js. The reviewer suggested refactoring the new-release.sh script to automate version detection and accept command-line arguments, noting that the current manual update process is brittle and error-prone.
Comment on lines
+7
to
+11
| old_version_code=20260428 | ||
| new_version_code=20260508 | ||
|
|
||
| old_version="1\.12\.40" | ||
| new_version="1\.13\.0" | ||
| old_version="1\.13\.0" | ||
| new_version="1\.13\.1" |
There was a problem hiding this comment.
The manual update of version strings and codes in this script is brittle and error-prone. Additionally, escaping dots in the new_version variable (e.g., 1\.13\.1) is unnecessary for the replacement part of a sed command and makes the variable less useful if it were to be used in other contexts like logging or printing.
Consider refactoring the script to accept the new version as a command-line argument and automatically detect the current version from CMakeLists.txt. This would eliminate the need to manually edit this script for every release and reduce the risk of inconsistencies.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores