Add static IP support for all nodes when Network is IPAM Managed #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR extends static IP assignment to all k3d nodes (both server and agent roles) when the network is IPAM managed, rather than only assigning static IPs to server nodes. This prevents issues that occur when Docker assigns different IPs to nodes after host reboots or daemon reloads.
- The static IP assignment logic is moved outside the
ServerRole-specific conditional block - Both server and agent nodes now receive static IPs when
cluster.Network.IPAM.Managedis true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add static IP support for all nodes when Network is IPAM Managed
Why
Static IP is currently only supported for nodes with server role. This causes issues when docker decided to give different IPs to the nodes after a host reboot / daemon reload / ...
Implications
When the network is IPAM managed, both server and agent nodes will receive a static IP address instead of only the server roles.