Skip to content

fix(cluster): resolve race condition causing "No nodes found" with rootless podman #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnrichardrinehart wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cluster): resolve race condition causing "No nodes found" with rootless podman #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions pkg/client/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,20 @@ func ClusterRun(ctx context.Context, runtime k3drt.Runtime, clusterConfig *confi
return fmt.Errorf("Failed Cluster Preparation: %+v", err)
}

// Create tools-node for later steps

g, _ := errgroup.WithContext(ctx)
g.Go(func() error {
_, err := EnsureToolsNode(ctx, runtime, &clusterConfig.Cluster)
return err
})

/*
* Step 1: Create Containers
*/
if err := ClusterCreate(ctx, runtime, &clusterConfig.Cluster, &clusterConfig.ClusterCreateOpts); err != nil {
return fmt.Errorf("failed Cluster Creation: %+v", err)
}

// Wait for tools node to be available
if err := g.Wait(); err != nil {
// Create tools-node after cluster containers exist so ClusterGet can find them.
// This must happen after ClusterCreate because EnsureToolsNode calls ClusterGet
// to discover the cluster's network and image volume from existing node labels.
// Running this in parallel with ClusterCreate caused race conditions where
// ClusterGet would fail with "No nodes found" on slower container runtimes
// (particularly rootless Podman).
if _, err := EnsureToolsNode(ctx, runtime, &clusterConfig.Cluster); err != nil {
return fmt.Errorf("failed to ensure tools node: %w", err)
}

Expand Down