Reduce default helm install job resources (remove 32 CPU / 32G limits) - #336
Closed
binbashing wants to merge 1 commit into
Closed
Reduce default helm install job resources (remove 32 CPU / 32G limits)#336binbashing wants to merge 1 commit into
binbashing wants to merge 1 commit into
Conversation
Signed-off-by: Matt Mahoney <binbashing@gmail.com>
binbashing
force-pushed
the
fix/default-job-resources-no-high-limits
branch
from
July 13, 2026 03:45
1bc3338 to
6e5facb
Compare
Member
|
No, this is intentional; see #301 for rationale. See #324 (comment) if you want to configure or disable these limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the high default limits from
--job-resourcesin helm-controller.Current default includes:
That default propagates to generated
helm-install-*Jobs (for example Traefik install jobs in K3s), causing misleading capacity/monitoring signals.Change
Why
JOB_RESOURCES.Validation
go test ./...Related