Validate that installed release has desired state - #337
Merged
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
vitorsavian
approved these changes
Jul 15, 2026
brandond
force-pushed
the
release-hash-check
branch
7 times, most recently
from
July 15, 2026 20:01
8b916c1 to
a077c1f
Compare
Inject config hash into release labels, and validate that the installed release has the correct hash. If the job is complete but the hash does not match, the job needs to be recreated. This also updates the hash to cover the job spec.template, so that changes to job configuration or spec.set values modify the hash to trigger a new release. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
release-hash-check
branch
from
July 15, 2026 20:19
a077c1f to
bb56c3b
Compare
matttrach
approved these changes
Jul 15, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject config hash into release labels, and validate that the installed release has the correct hash. If the job is complete but the hash does not match, the job needs to be recreated.
Fixes an issue where unexpected releases created after the job was created could leave the chart stuck without updating. The expected-revision check in the job image would correctly prevent the chart from being updated in conflict, but the controller would not trigger an update to the job to apply the change, because it did not have any way to detect that the installed release is out of sync with the desired state.
The chart controller now checks the latest release once the job is complete. If the release is deployed but does not have the expected hash, the job is recreated.
Needs: