Skip to content

[release/0.16] Validate that installed release has desired state #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandond merged 2 commits into from
Jul 15, 2026
Merged

[release/0.16] Validate that installed release has desired state #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b844d72
Fix logrus logging for klog levels that map to trace (>1)
brandond Jul 14, 2026
1e3d819
Validate that installed release has desired state
brandond Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,18 @@ const (
readyDuration = time.Minute * 1
)

func SetupLogging(debug bool) (logr.Logger, error) {
func SetupLogging(debug bool, level int) (logr.Logger, error) {
klog.EnableContextualLogging(true)
if debug {
logrus.SetLevel(logrus.DebugLevel)
}
return common.NewLogrusSink(nil).AsLogr(), nil
if level >= 2 {
logrus.SetLevel(logrus.TraceLevel)
}
logrus.SetFormatter(&logrus.TextFormatter{DisableQuote: true})
logger := common.NewLogrusSink(nil).AsLogr()
klog.SetLoggerWithOptions(logger, klog.ContextualLogger(true))
return logger, nil
}

func Run(ctx context.Context, hc config.CLI) error {
Expand All @@ -43,7 +49,7 @@ func Run(ctx context.Context, hc config.CLI) error {
log.Println(http.ListenAndServe(fmt.Sprintf("localhost:%d", hc.PprofPort), nil))
}()
}
logger, err := SetupLogging(hc.Debug)
logger, err := SetupLogging(hc.Debug, hc.DebugLevel)
if err != nil {
return err
}
Expand Down
Loading
Loading