-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix excessive load when bootstrapping P2P peers from servers configured in a join loop #12154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brandond
merged 3 commits into
k3s-io:master
from
brandond:fix-spegel-bootstrap-recursion
Apr 17, 2025
Merged
Fix excessive load when bootstrapping P2P peers from servers configured in a join loop #12154
brandond
merged 3 commits into
k3s-io:master
from
brandond:fix-spegel-bootstrap-recursion
Apr 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12154 +/- ##
==========================================
+ Coverage 45.13% 45.20% +0.06%
==========================================
Files 189 188 -1
Lines 19212 19210 -2
==========================================
+ Hits 8672 8683 +11
+ Misses 9305 9294 -11
+ Partials 1235 1233 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknola
previously approved these changes
Apr 16, 2025
2fdc62b to
294176c
Compare
libp2p may make a large number of bootstrap calls during startup; serve nodes from cache to avoid excessive CPU usage. Signed-off-by: Brad Davidson <[email protected]>
Adds maximum in-flight request limits to agent join and p2p peer info request request handlers. Signed-off-by: Brad Davidson <[email protected]>
Avoids infinite recursion when the chain includes an agentBootstrapper with a server address that points back at this node (via join address loop or external LB) Signed-off-by: Brad Davidson <[email protected]>
294176c to
a69a65f
Compare
dereknola
approved these changes
Apr 17, 2025
This was referenced Apr 17, 2025
matttrach
approved these changes
Apr 17, 2025
VestigeJ
approved these changes
Apr 17, 2025
This was referenced Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
libp2p may make a large number of bootstrap calls during startup; serve nodes from cache to avoid excessive CPU usage.
Adds maximum in-flight request limits to agent join and p2p peer info request request handlers.
Avoids infinite recursion when the chain includes an agentBootstrapper with a server address that points back at this node (via join address loop or external LB)
Types of Changes
bugfix
Verification
See linked issue: #12127 (comment)
cluster-init: true.cluster-init: truefrom server1 , and addserver: https://server3:6443instead.kubectl get --raw /v1-k3s/p2pon any one of the servers.Serving p2p peer addrsmessage in the logs.Testing
Linked Issues
User-Facing Change
Further Comments