-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix sonobuoy conformance testing #12214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
VestigeJ
approved these changes
Apr 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12214 +/- ##
==========================================
+ Coverage 45.13% 45.15% +0.02%
==========================================
Files 188 188
Lines 19219 19221 +2
==========================================
+ Hits 8675 8680 +5
+ Misses 9310 9308 -2
+ Partials 1234 1233 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brandond
approved these changes
Apr 25, 2025
manuelbuil
approved these changes
Apr 28, 2025
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2025
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2025
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2025
Signed-off-by: Derek Nola <[email protected]>
This was referenced May 2, 2025
brandond
pushed a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Derek Nola <[email protected]>
brandond
pushed a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Derek Nola <[email protected]>
brandond
pushed a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
See failures on the nightly runs around
At some point the VERSION_K8S stopped getting passed correctly down the script layers to the actual sonobuoy call.
We just need to properly export this so its available to the subprocess.
Types of Changes
Verification
Manually run locally and SERIAL and PARALLEL tests now correctly launch.
Testing
Linked Issues
#11714
User-Facing Change
Further Comments
We can't move forward with GHA migration until we are in a stable place with the old tests.