feat: add tolerations support#820
Open
preko-p wants to merge 1 commit into
Open
Conversation
|
4080ef3 to
ab6a788
Compare
Signed-off-by: preko06 <istvan.orban@workl.com> Signed-off-by: preko-p <278021202+preko-p@users.noreply.github.com>
ab6a788 to
d3ccaf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.tolerationssupport toK8sGPTcustom resourcescontrollerManager.tolerationsto the operator Helm chart and render it in the controller-manager DeploymentFixes #767.
Tests
go test ./api/v1alpha1 ./pkg/resourceshelm template release chart/operatorhelm template release chart/operator --set 'controllerManager.tolerations[0].key=dedicated' --set 'controllerManager.tolerations[0].operator=Equal' --set 'controllerManager.tolerations[0].value=ai' --set 'controllerManager.tolerations[0].effect=NoSchedule'helm lint chart/operatorgit diff --checkmake generateandmake manifestscould not complete in my local macOS environment because the locally builtcontroller-genbinary aborts withdyld: missing LC_UUID load command. The corresponding deepcopy and CRD schema updates are included in this patch.