feat: add resources analyzer for missing requests/limits#1608
Open
praveen0612 wants to merge 1 commit intok8sgpt-ai:mainfrom
Open
feat: add resources analyzer for missing requests/limits#1608praveen0612 wants to merge 1 commit intok8sgpt-ai:mainfrom
praveen0612 wants to merge 1 commit intok8sgpt-ai:mainfrom
Conversation
Signed-off-by: Praveen Kumar <kumarpraveen@adobe.com>
AlexsJones
added
documentation
Contributor
three-foxes-in-a-trenchcoat
left a comment
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
Good new analyzer. Missing resource requests/limits is a real operational pain point.
Notes:
- Starting with Deployments only is a safe approach. Consider noting in a comment that it can be extended to StatefulSets and Jobs in follow-up PRs.
- The initContainers check is a nice touch — often overlooked.
- Consider adding a metric label for the container type (container vs initContainer) for easier dashboarding.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks
ℹ Additional Information