fix: use lowercase github owner for helm

[rollandf]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential issue with case sensitivity when interacting with Helm charts by ensuring that the GITHUB_REPO_OWNER variable is always processed as lowercase. This standardization prevents errors that could arise from inconsistent casing, improving the reliability of chart pushing and updating operations.

Highlights

• GitHub Repo Owner Case: Ensured that the GITHUB_REPO_OWNER environment variable is consistently converted to lowercase before use in Helm-related scripts.

Changelog

• hack/release/chart-push.sh
  • Converted the GITHUB_REPO_OWNER variable to lowercase using tr '[:upper:]' '[:lower:]'.
• hack/release/chart-update.sh
  • Converted the GITHUB_REPO_OWNER variable to lowercase using tr '[:upper:]' '[:lower:]'.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coveralls]

Pull Request Test Coverage Report for Build 22661858861

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.06%) to 45.495%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controller/resourcefiltercontroller.go	2	74.38%

Totals
Change from base Build 22566630702:	-0.06%
Covered Lines:	1434
Relevant Lines:	3152

---

💛 - Coveralls

[gemini-code-assist]

Code Review

This pull request correctly ensures that the "GITHUB_REPO_OWNER" variable is converted to lowercase for Helm chart operations, which is a necessary fix for compatibility with container registries like ghcr.io. However, the scripts introduce security vulnerabilities due to improper handling of environment variables. Specifically, "GITHUB_REPO_OWNER" is used in "yq" expressions without escaping in "chart-update.sh", allowing for expression injection, and is used in multiple shell commands without double quotes in both scripts, allowing for argument injection. While the implementation is functional, I've also provided suggestions for more efficient bash constructs. It is recommended to use "yq"'s "env()" function for variable injection and to ensure all shell variables are properly quoted to mitigate these security risks.

[rollandf]

/gemini review

[gemini-code-assist]

Code Review

This pull request ensures the GitHub owner is in lowercase for Helm commands. The change is functional, but it highlights duplicated logic across two scripts. I've added a comment with a suggestion to refactor this for better maintainability.

[gemini-code-assist]

This logic for initializing and lowercasing GITHUB_REPO_OWNER is duplicated in hack/release/chart-update.sh. Both scripts also share similar logic for handling GITHUB_TOKEN and VERSION environment variables and their validation. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, consider extracting this common setup into a shared script (e.g., hack/release/common.sh) and sourcing it in both chart-push.sh and chart-update.sh.