Skip to content

Comments

[release-0.47] optimize init map ns#557

Merged
RamLavi merged 4 commits intok8snetworkplumbingwg:release-0.47from
RamLavi:release-0.47_optimize_init_map_ns
Aug 19, 2025
Merged

[release-0.47] optimize init map ns#557
RamLavi merged 4 commits intok8snetworkplumbingwg:release-0.47from
RamLavi:release-0.47_optimize_init_map_ns

Conversation

@RamLavi
Copy link
Member

@RamLavi RamLavi commented Aug 6, 2025

What this PR does / why we need it:
This is a manual cherry-pick of #556

Special notes for your reviewer:

Release note:

NONE

RamLavi added 3 commits August 6, 2025 17:03
Currently kubemacpool scans all pods cluster-wide and performs expensive
IsPodManaged() checks for each pod during startup. This causes slow
initialization in large clusters with many unmanaged namespaces.

Pre-compute managed namespaces once per webhook type and only scan pods
from those namespaces, eliminating redundant API calls and reducing
startup time.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Currently kubemacpool scans all VMs cluster-wide and performs expensive
IsVMManaged() checks for each VM during startup. This causes slow
initialization in large clusters with many unmanaged namespaces.

Pre-compute managed namespaces once per webhook type and only scan VMs
from those namespaces, eliminating redundant API calls and reducing
startup time.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
To anticipate big clusters with 10K VMs, increasing the readiness probe
settle time to 3m.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
@RamLavi
Copy link
Member Author

RamLavi commented Aug 7, 2025

/hold

trying to debug the new flake

@RamLavi
Copy link
Member Author

RamLavi commented Aug 7, 2025

issue is not relevant to this failed test.
/override pull-kubemacpool-e2e-k8s

@kubevirt-bot
Copy link
Collaborator

@RamLavi: Overrode contexts on behalf of RamLavi: pull-kubemacpool-e2e-k8s

Details

In response to this:

issue is not relevant to this failed test.
/override pull-kubemacpool-e2e-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Member Author

RamLavi commented Aug 7, 2025

/hold cancel

@RamLavi
Copy link
Member Author

RamLavi commented Aug 7, 2025

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

@RamLavi: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Collaborator

@maiqueb: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi RamLavi merged commit d610744 into k8snetworkplumbingwg:release-0.47 Aug 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants