[release-0.49] Decouple readiness from controller-runtime startup#571
Merged
kubevirt-bot merged 2 commits intok8snetworkplumbingwg:release-0.49from Nov 4, 2025
Conversation
… ready Currently both liveness and readiness probes are bound by the poolManager being ready. This makes no sense, as the pod is responsive even though the pool is being constructed. - Decouple controller-runtime Manager startup from poolManager startup to prevent liveness failures during pool initialization unless there is a real connection issue. - Add readiness probe wait mechanism to explicitly wait for the pool to be ready. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Currently the kubemacpool service is set to answer webhook calls even if the manager is not ready. This is not the desired behavior - webhook should not answer VMs until pool is ready. Removing publishNotReadyAddresses from the webhook service. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Member
|
/lgtm |
Collaborator
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
merged commit 77b1d23
into
k8snetworkplumbingwg:release-0.49
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #570
/assign RamLavi