Remove kubevirt dependencies by RamLavi · Pull Request #574 · k8snetworkplumbingwg/kubemacpool

RamLavi · 2025-11-06T21:22:32Z

What this PR does / why we need it:
This PR removes the dependency with kubevirt/go-client and makes the vendor much more easy to maintain.
the virtctl client is removed in favor of controller runtime client.

Special notes for your reviewer:

Release note:

NONE

RamLavi · 2025-11-07T08:53:01Z

/cherry-pick release-0.49

kubevirt-bot · 2025-11-07T08:53:05Z

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.49 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ormergi

Very nice cleanup

ormergi · 2025-11-09T13:52:13Z

tests/tests.go

+	_ = corev1.AddToScheme(scheme)
+	_ = v1.AddToScheme(scheme)


It seems there is no need to register those (corev1, app/v1 clients), k8sClient should provide these clients, right?

right. DONE

ormergi · 2025-11-09T13:53:15Z

tests/tests.go

@@ -67,16 +71,42 @@ var (

 type TestClient struct {
 	VirtClient kubecli.KubevirtClient


Please consider marking VirtClient as deprecated with message saying controller-runtime client should be used instead.

it's going away in next commit by why not.
DONE

ormergi · 2025-11-09T13:56:13Z

tests/range_day2_test.go

+	err := testClient.CRClient.Get(context.Background(),
+		client.ObjectKey{Namespace: vm.Namespace, Name: vm.Name}, updatedVM)
 	if err != nil {


nit: Please consider in-lining the condition clause for reducing scope of returned values.
Here and in other occurrences.

let's to it in a follow up PR, this one has too much going on it as it is :)

ormergi · 2025-11-09T13:57:46Z

tests/tests.go

 		var err error
-		virtualMachine, err = testClient.VirtClient.VirtualMachine(virtualMachine.Namespace).Get(context.TODO(),
-			virtualMachine.Name, metav1.GetOptions{})
+		err = testClient.CRClient.Get(context.TODO(),


context.TODO is deprecated, please use context.Background. Here and in other occurrences.

Dont we have linter rule for that? 🤔

Same - I'll do it in a follow up

Dont we have linter rule for that? 🤔

donno, but I'll see if the linter needs bumping..

ormergi · 2025-11-09T14:01:54Z

tests/tests.go

 )

 type TestClient struct {
-	VirtClient kubecli.KubevirtClient


Ah so this is removed eventually.. please consider mentioning in the first commit message virtClient is going to be removed in follow-up commit.

It's written but maybe I should also explicitly state it as depreacted for formality

Nahh I dont think its necessary because its gone in the same PR, I already reviewed it and aware of the changes.

already did :-p

oshoval · 2025-11-09T14:08:41Z

please consider adding on PR desc that it was removed in favor of using controller runtime

Introduce kubernetes.Interface and controller-runtime client to TestClient structure while keeping the existing VirtClient for backward compatibility. This allows gradual migration of test code without breaking existing tests. Signed-off-by: Ram Lavi <ralavi@redhat.com>

This covers all standard Kubernetes operations (Pods, Deployments, Namespaces, ConfigMaps, Secrets, etc). Signed-off-by: Ram Lavi <ralavi@redhat.com>

Replace all VirtualMachine CRUD operations from kubevirt client-go typed client to controller-runtime client. Signed-off-by: Ram Lavi <ralavi@redhat.com>

Remove VirtClient field and kubecli dependency from test infrastructure since all operations now use kubernetes.Interface and controller-runtime client. Signed-off-by: Ram Lavi <ralavi@redhat.com>

Remove kubevirt.io/client-go from go.mod All kubevirt API operations now use controller-runtime client with kubevirt.io/api types. This commit consists of the 'make vendor' changes. Signed-off-by: Ram Lavi <ralavi@redhat.com>

RamLavi · 2025-11-09T14:35:35Z

Change: Address @ormergi 's review
PTAL

ormergi

Thanks for the changes

RamLavi · 2025-11-09T14:40:28Z

/approve

kubevirt-bot · 2025-11-09T14:40:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RamLavi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2025-11-09T15:17:48Z

@RamLavi: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

Details

In response to this:

/cherry-pick release-0.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

oshoval · 2025-11-09T15:19:25Z

{"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

funny one

kubevirt-bot added release-note-none dco-signoff: yes labels Nov 6, 2025

kubevirt-bot requested review from oshoval and qinqon November 6, 2025 21:22

kubevirt-bot added the size/XXL label Nov 6, 2025

RamLavi mentioned this pull request Nov 9, 2025

Bump vendors: k8s.io, controller-runtime, kubevirt/api #575

Merged

ormergi reviewed Nov 9, 2025

View reviewed changes

RamLavi added 5 commits November 9, 2025 16:29

Replace VirtClient standard calls with K8sClient equivalents.

ade1e4f

This covers all standard Kubernetes operations (Pods, Deployments, Namespaces, ConfigMaps, Secrets, etc). Signed-off-by: Ram Lavi <ralavi@redhat.com>

tests: Migrate VirtualMachine operations to controller-runtime client

f519a19

Replace all VirtualMachine CRUD operations from kubevirt client-go typed client to controller-runtime client. Signed-off-by: Ram Lavi <ralavi@redhat.com>

tests: remove kubecli.KubevirtClient from TestClient

91350e3

Remove VirtClient field and kubecli dependency from test infrastructure since all operations now use kubernetes.Interface and controller-runtime client. Signed-off-by: Ram Lavi <ralavi@redhat.com>

vendor: Remove kubevirt.io/client-go dependency

d1e7bfa

Remove kubevirt.io/client-go from go.mod All kubevirt API operations now use controller-runtime client with kubevirt.io/api types. This commit consists of the 'make vendor' changes. Signed-off-by: Ram Lavi <ralavi@redhat.com>

RamLavi force-pushed the remove-kubevirt-dependencies branch from 6b5cf61 to d1e7bfa Compare November 9, 2025 14:34

ormergi approved these changes Nov 9, 2025

View reviewed changes

kubevirt-bot assigned ormergi Nov 9, 2025

kubevirt-bot added the lgtm label Nov 9, 2025

kubevirt-bot added the approved label Nov 9, 2025

kubevirt-bot merged commit fc28dd8 into k8snetworkplumbingwg:main Nov 9, 2025
5 checks passed

		@@ -67,16 +71,42 @@ var (

		type TestClient struct {
		VirtClient kubecli.KubevirtClient

Comments

Conversation

RamLavi commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RamLavi commented Nov 7, 2025

Uh oh!

kubevirt-bot commented Nov 7, 2025

Uh oh!

ormergi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval commented Nov 9, 2025

Uh oh!

RamLavi commented Nov 9, 2025

Uh oh!

ormergi left a comment

Choose a reason for hiding this comment

Uh oh!

RamLavi commented Nov 9, 2025

Uh oh!

kubevirt-bot commented Nov 9, 2025

Uh oh!

Uh oh!

kubevirt-bot commented Nov 9, 2025

Uh oh!

oshoval commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RamLavi commented Nov 6, 2025 •

edited

Loading