[release-0.49] Optimize init pool: Reduce VM/Pod API calls #578
Merged
kubevirt-bot merged 6 commits intok8snetworkplumbingwg:release-0.49from Nov 17, 2025
Merged
Conversation
…y usage Introduce pagination with 500 namespaces per page when gathering managed namespaces during initialization. This prevents loading all namespaces into memory at once in clusters with thousands of namespaces. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Change getManagedNamespaces to return map[string]struct{} instead of
[]string, making it more idiomatic Go.
This set will be used in future commits to easily check whether a ns is
managed or not.
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Currently during VM pool map init, only managed namespaces are called, but for each we do an API call, which can be slow in clusters with large number of namespaces. Replace per-namespace VM listing with cluster-wide listing and in-memory filtering, while keeping the pagination to avoid over using the memory. This dramatically reduces API calls during initialization. The Trade-off is fetching VMs from unmanaged namespaces then filters them out, but the network overhead is negligible compared to the latency savings from fewer round trips. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Increase the pagination limit from 100 to 500 when fetching VMs during initialization. This further reduces API calls by fetching larger batches. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Currently during Pod pool map init, only managed namespaces are called, but for each we do an API call, which can be slow in clusters with large number of namespaces. Replace per-namespace Pod listing with cluster-wide listing and in-memory filtering, while keeping the pagination to avoid over using the memory. This dramatically reduces API calls during initialization. The Trade-off is fetching Pods from unmanaged namespaces then filters them out, but the network overhead is negligible compared to the latency savings from fewer round trips. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Increase the pagination limit from 100 to 500 when fetching Pods during initialization. This further reduces API calls by fetching larger batches. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Member
|
/lgtm |
Collaborator
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b88da8b
into
k8snetworkplumbingwg:release-0.49
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #577
/assign RamLavi