Skip to content

logs: Set verbosity to reduce info level noise #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubevirt-bot merged 1 commit into from
Nov 23, 2025
Merged

logs: Set verbosity to reduce info level noise #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/configmap/configmap_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (r *ConfigMapReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
return ctrl.Result{}, err
}

logger.Info("Processing ConfigMap for MAC range update")
logger.V(2).Info("Processing ConfigMap for MAC range update")

// Extract and validate new MAC ranges from ConfigMap
rangeConfig, err := r.extractRangesFromConfigMap(configMap)
Expand All @@ -115,7 +115,7 @@ func (r *ConfigMapReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
// Check if the new ranges are different from current ranges
currentStart, currentEnd := r.PoolManager.GetCurrentRanges()
if rangeConfig.Start.String() == currentStart && rangeConfig.End.String() == currentEnd {
logger.Info("MAC address ranges unchanged, skipping update",
logger.V(2).Info("MAC address ranges unchanged, skipping update",
"currentRangeStart", currentStart,
"currentRangeEnd", currentEnd)
return ctrl.Result{}, nil
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/virtualmachine/virtualmachine_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (r *ReconcilePolicy) Reconcile(ctx context.Context, request reconcile.Reque
//used for multi thread log separation
reconcileRequestId := rand.Intn(100000)
logger := log.WithName("Reconcile").WithValues("RequestId", reconcileRequestId, "vmFullName", fmt.Sprintf("vm/%s/%s", request.Namespace, request.Name))
logger.Info("got a virtual machine event in the controller")
logger.V(1).Info("got a virtual machine event in the controller")

instance := &kubevirt.VirtualMachine{}
err := r.Get(ctx, request.NamespacedName, instance)
Expand Down
2 changes: 1 addition & 1 deletion pkg/pool-manager/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func CreateTransactionTimestamp() time.Time {
func SetTransactionTimestampAnnotationToVm(virtualMachine *kubevirt.VirtualMachine, transactionTimestamp time.Time) {
timeStampAnnotationValue := transactionTimestamp.Format(time.RFC3339Nano)
virtualMachine.Annotations[TransactionTimestampAnnotation] = timeStampAnnotationValue
log.Info("added TransactionTimestamp Annotation", "ts", timeStampAnnotationValue)
log.V(1).Info("added TransactionTimestamp Annotation", "ts", timeStampAnnotationValue)
}

func GetTransactionTimestampAnnotationFromVm(virtualMachine *kubevirt.VirtualMachine) (time.Time, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/pool-manager/virtualmachine_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func (p *PoolManager) MarkVMAsReady(vm *kubevirt.VirtualMachine, latestPersisted
if err != nil {
return errors.Wrapf(err, "Failed to get VmMacMap for vm %s", vmFullName)
}
logger.Info("Macs currently set on vm", "vmMacMap", vmMacMap)
logger.V(1).Info("Macs currently set on vm", "vmMacMap", vmMacMap)

err = vmMacMap.filterMacsThatRequireCommit(latestPersistedTransactionTimeStamp, logger)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions pkg/webhook/virtualmachine/virtualmachine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func patchVMChanges(originalVirtualMachine, currentVirtualMachine *kubevirt.Virt
}
}

logger.Info("patchVMChanges", "kubemapcoolJsonPatches", kubemapcoolJsonPatches)
logger.V(1).Info("patchVMChanges", "kubemapcoolJsonPatches", kubemapcoolJsonPatches)
if len(kubemapcoolJsonPatches) == 0 {
return admission.Response{
Patches: kubemapcoolJsonPatches,
Expand Down Expand Up @@ -206,7 +206,7 @@ func (a *virtualMachineAnnotator) mutateCreateVirtualMachinesFn(virtualMachine *
// mutateUpdateVirtualMachinesFn calls the update allocation function
func (a *virtualMachineAnnotator) mutateUpdateVirtualMachinesFn(virtualMachine *kubevirt.VirtualMachine, isNotDryRun bool, parentLogger logr.Logger) error {
logger := parentLogger.WithName("mutateUpdateVirtualMachinesFn")
logger.Info("got an update mutate virtual machine event")
logger.V(1).Info("got an update mutate virtual machine event")
previousVirtualMachine := &kubevirt.VirtualMachine{}
err := a.client.Get(context.TODO(), client.ObjectKey{Namespace: virtualMachine.Namespace, Name: virtualMachine.Name}, previousVirtualMachine)
if err != nil {
Expand Down