OCPBUGS-79676: Fix hardware and ptp profile association#187
Merged
lack merged 1 commit intok8snetworkplumbingwg:mainfrom Apr 8, 2026
Merged
OCPBUGS-79676: Fix hardware and ptp profile association#187lack merged 1 commit intok8snetworkplumbingwg:mainfrom
lack merged 1 commit intok8snetworkplumbingwg:mainfrom
Conversation
Align hardware config - ptp config association logic with the new naming scheme, where profile names are prefixed with resource name sepaated by "_". Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
|
Thanks for your PR, |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function ptpProfileNameMatchesActive to handle PTP profile name matching, including support for suffix matching with a _ separator. This logic is integrated into calculateNodeHardwareConfigs and checkIfChangedConfigsAffectActiveProfiles, with the latter also optimized by using a map for profile lookups. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align hardware config - ptp config association logic with the new naming scheme, where profile names are prefixed with resource name sepaated by "_".
/cc @nocturnalastro