Give precendence to IPBlock field over PodSelector#77
Merged
zeeke merged 2 commits intok8snetworkplumbingwg:masterfrom Sep 30, 2025
Merged
Give precendence to IPBlock field over PodSelector#77zeeke merged 2 commits intok8snetworkplumbingwg:masterfrom
zeeke merged 2 commits intok8snetworkplumbingwg:masterfrom
Conversation
and split them in multple smaller functions. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
As per API description [1]: > IPBlock defines policy on a particular IPBlock. If this field is set then neither of the other fields can be." if a policy rule has a from/to rule with an IPBlock field, then the PodSelector and NamespaceSelector fields must be ignored. [1] https://github.com/k8snetworkplumbingwg/multi-networkpolicy/blob/master/scheme.yml#L88 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Pull Request Test Coverage Report for Build 15607622077Details
💛 - Coveralls |
|
Fix included in accepted release 4.21.0-0.nightly-2025-11-05-234508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per API description [1]:
if a policy rule has a from/to rule with an IPBlock field,
then the PodSelector and NamespaceSelector fields must be ignored.
[1] https://github.com/k8snetworkplumbingwg/multi-networkpolicy/blob/master/scheme.yml#L88
this PR also contains a refactor around
renderIngressFromandrenderEgressTo.