Skip to content

fix error checking in validateIfName #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myl2821 wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix error checking in validateIfName #1485

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90c0984
fix error checking in validateIfName
Mar 12, 2026
468e809
Apply suggestion from @gemini-code-assist[bot]
myl2821 Mar 12, 2026
b158733
Fix type of LinkNotFoundError variable
myl2821 Mar 12, 2026
e28f1e6
Fix variable declaration for LinkNotFoundError
myl2821 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/multus/multus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func validateIfName(nsname string, ifname string) error {
err = podNs.Do(func(_ ns.NetNS) error {
_, err := netlink.LinkByName(ifname)
if err != nil {
if err.Error() == "Link not found" {
if _, ok := err.(netlink.LinkNotFoundError); ok {
return nil
}
return err
Expand Down