Update to k8s 1.34.1, go 1.24 and multus-cni v4.2.3 #295
Conversation
mgfritch
force-pushed
the
k8s-1.34.1_go1.24
branch
from
1424c07 to
d7e1347
Compare
mgfritch
force-pushed
the
k8s-1.34.1_go1.24
branch
from
d7e1347 to
8c4e93c
Compare
|
I haven't forgotten, but this is quite big, and I need to take some time to go over it. I will try to provide feedback by the end of next week. Huge thanks for the contribution. I'll keep in touch. |
- Remove explicit pin to k8s 1.29.1 - Update to go 1.24 - Update to k8s 1.34.1 - Update to multus-cni v4.2.3 Signed-off-by: Michael Fritch <[email protected]>
SA1019: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (staticcheck) SA1019: workqueue.NewRateLimitingQueueWithConfig is deprecated: Use NewTypedRateLimitingQueueWithConfig instead. (staticcheck) SA1019: workqueue.DefaultControllerRateLimiter is deprecated: Use DefaultTypedControllerRateLimiter instead. (staticcheck) SA1019: workqueue.RateLimitingQueueConfig is deprecated: Use TypedRateLimitingQueueConfig instead. (staticcheck) Signed-off-by: Michael Fritch <[email protected]>
mgfritch
force-pushed
the
k8s-1.34.1_go1.24
branch
from
8c4e93c to
4a93af2
Compare
| broadcaster record.EventBroadcaster | ||
| recorder record.EventRecorder | ||
| workqueue workqueue.RateLimitingInterface | ||
| workqueue workqueue.TypedRateLimitingInterface[*string] |
There was a problem hiding this comment.
| workqueue workqueue.TypedRateLimitingInterface[*string] | |
| workqueue workqueue.TypedRateLimitingInterface[types.NamespacedName] |
It might make sense to use types.NamespacedName here, but that's likely a larger refactor better suited for a new PR.
Thanks!
The failing |
mgfritch
changed the title
| github.com/opencontainers/runtime-spec v1.2.1 | ||
| google.golang.org/grpc v1.73.0 | ||
| gopkg.in/k8snetworkplumbingwg/multus-cni.v4 v4.2.3 | ||
| k8s.io/api v0.34.1 |
There was a problem hiding this comment.
can you please move the k8s ones to v0.34.2
3 participants
What this PR does / why we need it:
The following dependabot PRs have become stale:
Which issue(s) this PR fixes
Special notes for your reviewer (optional):
The explicit pin to k8s 1.29.1 was required while using k8s.io/client-go v1.5.2 (obsolete), but it confuses the dependabot automation and it's no longer needed when using k8s 1.34.1 (k8s.io/client-go v0.43.1)
Validation
make build && make test