Open
Conversation
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
This commit refactors the previously added test into a table that clearly proves that updating the interface name of an existing attachment actually causes the original attachment to be removed, since this "update" is recognized by the controller as a sequence of: - attach new interface (with the interface name specified) - remove old interface The first action fails, since that interface name is already present within the system, while the second succeeds. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
expose-issue66-via-unit-test
branch
from
3cd8708 to
e7e550e
Compare
maiqueb
commented
Nov 17, 2022
| InterfaceRequest: "net0", | ||
| MacRequest: "07:06:05:04:03:02", | ||
| }), | ||
| XEntry("when the iface name is updated", nad.NetworkSelectionElement{ |
Collaborator
Author
There was a problem hiding this comment.
This is wrong; the original attachment does feature the interface name.
We need to somehow have a pod with a provisioned attachment that does not specify the interface name on the network selection elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a unit test that exposes the bug described in issue #66 .
It furthermore shows that updates to the MAC address (for instance) of an existing attachment do work as expected.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):
Depends-on: #83