Ability to specify vlan_mode in the network configuration

[daghaian]

What this PR does / why we need it:

Adds a needed ability for specifying VLAN mode to be applied to the attached port instead of defaulting to trunk/access. This enables usage for cases in which the port should operate under one of the alternative VLAN modes: native-untagged, native-tagged, or dot1q-tunnel. In addition, the existing logic for when tags/trunks were applied to the created port was changed to allow for both to be applied to a port when used in conjunction with an access mode such as native-untagged. Please see https://man7.org/linux/man-pages/man5/ovs-vswitchd.conf.db.5.html for any additional clarification.

Special notes for your reviewer:
N/A

Release note:

Added the ability to set `vlan_mode` via a new `vlan_mode` field in the Network Configuration

[kubevirt-bot]

Hi @daghaian. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[daghaian]

/assign @phoracek

[daghaian]

Bumping this issue to see if someone can take a look. Thanks!

[phoracek]

/retest

[kubevirt-bot]

@daghaian: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-e2e-ovs-cni	c885d62	link	true	/test pull-e2e-ovs-cni

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[phoracek]

This fails the linter check

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daghaian
Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mw-0]

I could do with these changes. Has it been abandoned? @phoracek Was it just the linter change that was the problem?

[phoracek]

@mw-0 I have not reviewed this in depth yet, but it looks conceptually ok to me. So if you push a new rebased PR, with linter resolved and tests passing, I'm happy to review it and help get it merged.

[daghaian]

I'm happy to rebase the PR when I have a moment. We've been running our own modified version with this change for a while now haha. Glad to hear it has a use for people :)