Skip to content

Bump golangci-linter version#353

Merged
phoracek merged 1 commit intok8snetworkplumbingwg:mainfrom
phoracek:linterbump
Mar 5, 2025
Merged

Bump golangci-linter version#353
phoracek merged 1 commit intok8snetworkplumbingwg:mainfrom
phoracek:linterbump

Conversation

@phoracek
Copy link
Member

@phoracek phoracek commented Mar 5, 2025

Without this change, the linter will fail on Ginkgo and Gomega dot imports.

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

Without this change, the linter will fail on Ginkgo and Gomega dot
imports.

Signed-off-by: Petr Horacek <phoracek@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 5, 2025
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@phoracek
Copy link
Member Author

phoracek commented Mar 5, 2025

/retest

@ksimon1
Copy link
Contributor

ksimon1 commented Mar 5, 2025

/lgtm

@kubevirt-bot
Copy link
Collaborator

@ksimon1: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@phoracek phoracek merged commit ef9d377 into k8snetworkplumbingwg:main Mar 5, 2025
4 of 5 checks passed
@phoracek
Copy link
Member Author

/cherry-pick release-0.38
/cherry-pick release-0.36

@kubevirt-bot
Copy link
Collaborator

@phoracek: new pull request created: #379

Details

In response to this:

/cherry-pick release-0.38
/cherry-pick release-0.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

@phoracek: cannot checkout release-0.38: error checking out "release-0.38": exit status 1 error: pathspec 'release-0.38' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-0.38
/cherry-pick release-0.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants