Skip to content

Comments

chore: bump sriovnet lib#403

Open
adrianchiris wants to merge 1 commit intok8snetworkplumbingwg:mainfrom
adrianchiris:bump-sriovnet
Open

chore: bump sriovnet lib#403
adrianchiris wants to merge 1 commit intok8snetworkplumbingwg:mainfrom
adrianchiris:bump-sriovnet

Conversation

@adrianchiris
Copy link
Contributor

@adrianchiris adrianchiris commented Aug 21, 2025

sriovnet lib contains fixes to handle local and remote VF representors co-existing.

this fix is relevant for case where ovs-cni run on DPU and there are VFs for both the external host and local VFs (which are used on the DPU itself)

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

@adrianchiris
chore: bump sriovnet lib
59a2f8a 
sriovnet lib contains fixes to handle local and remote
VF representors co-existing.

this fix is relevant for case where ovs-cni run on DPU
and there are VFs for both the external host and local
VFs (which are used on the DPU itself)

Signed-off-by: adrianc <adrianc@nvidia.com>
@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Aug 21, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2025
@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Aug 21, 2025

Hi @adrianchiris. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

SchSeba
SchSeba approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@SchSeba
Copy link
Collaborator

SchSeba commented Sep 8, 2025

/ok-to-test

@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2025
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2025
@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Nov 16, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SchSeba
Copy link
Collaborator

SchSeba commented Nov 23, 2025

Hi @adrianchiris can you please rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SchSeba SchSeba SchSeba approved these changes

Assignees

@SchSeba SchSeba

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianchiris @kubevirt-bot @SchSeba