chore(deps): update module golang.org/x/net to v0.45.0 [security] (main)#428
chore(deps): update module golang.org/x/net to v0.45.0 [security] (main)#428redhat-renovate-bot wants to merge 1 commit intomainfrom
Conversation
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-renovate-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @redhat-renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the security and stability of the project by updating core Go dependencies. It addresses known vulnerabilities in the HTML parsing library and incorporates various improvements and refactorings within the HTTP/2 stack, alongside a general update to the Go language version. The changes aim to ensure the application remains secure and performs optimally with the latest upstream fixes and features. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates golang.org/x/net and other dependencies, primarily to address critical security vulnerabilities CVE-2025-58190 (infinite parsing loop) and CVE-2025-47911 (quadratic parsing complexity) in the HTML parser. These changes effectively mitigate potential Denial of Service (DoS) attacks by introducing a hard limit of 512 nested elements in the insertOpenElement method and ensuring graceful error handling in the parse method within vendor/golang.org/x/net/html/parse.go. Beyond the security fixes, the PR also includes significant refactoring of the http2 package, introduces support for RFC 9218 (Extensible Priorities for HTTP), and incorporates general improvements such as a security enhancement to prevent URI misuse by checking for userinfo in the :authority pseudo-header in internal/httpcommon/request.go. While the security aspects are well-handled and no new vulnerabilities were introduced, a couple of minor issues related to clarity and maintainability were identified in the newly vendored code, which have been detailed in specific comments. Overall, this is a solid and necessary update that successfully integrates important security patches and follows best practices.
| if h2.MaxConcurrentStreams != 0 { | ||
| conf.MaxConcurrentStreams = uint32(h2.MaxConcurrentStreams) | ||
| } |
| @@ -0,0 +1,209 @@ | |||
| // Copyright 2025 The Go Authors. All rights reserved. | |||
There was a problem hiding this comment.
Signed-off-by: redhat-renovate-bot <redhat-internal-renovate@redhat.com>
1100d5c to
db77e36
Compare
This PR contains the following updates:
v0.43.0->v0.45.0Quadratic parsing complexity in golang.org/x/net/html
CVE-2025-47911 / GHSA-w4gw-w5jq-g9jh / GO-2026-4440
More information
Details
The html.Parse function in golang.org/x/net/html has quadratic parsing complexity when processing certain inputs, which can lead to denial of service (DoS) if an attacker provides specially crafted HTML content.
Severity
Unknown
References
This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).
Infinite parsing loop in golang.org/x/net
CVE-2025-58190 / GO-2026-4441
More information
Details
The html.Parse function in golang.org/x/net/html has an infinite parsing loop when processing certain inputs, which can lead to denial of service (DoS) if an attacker provides specially crafted HTML content.
Severity
Unknown
References
This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.