Skip to content

Reapply "Bump Go to 1.25 and golangci-lint (#421)" (#423)#433

Merged
kubevirt-bot merged 1 commit intok8snetworkplumbingwg:mainfrom
SchSeba:reapply-go-golangci-lint
Feb 26, 2026
Merged

Reapply "Bump Go to 1.25 and golangci-lint (#421)" (#423)#433
kubevirt-bot merged 1 commit intok8snetworkplumbingwg:mainfrom
SchSeba:reapply-go-golangci-lint

Conversation

@SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Feb 25, 2026

This reverts commit 45bdf0b.

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

None

k8snetworkplumbingwg#423)

This reverts commit 45bdf0b.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 25, 2026
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@SchSeba
Copy link
Collaborator Author

SchSeba commented Feb 25, 2026

Hi @oshoval @RamLavi can you please take a look?

@gemini-code-assist
Copy link

Note

The number of changes in this pull request is too large for Gemini Code Assist to generate a summary.

@oshoval
Copy link
Member

oshoval commented Feb 25, 2026

Thanks, is it pure revert or additional steps applied ?

@SchSeba
Copy link
Collaborator Author

SchSeba commented Feb 25, 2026

just revert I didn't change anything else

@oshoval
Copy link
Member

oshoval commented Feb 26, 2026

Thanks

/lgtm

lets update it please to 1.25.5 on follow-up / this PR, up to you, since this is the go version that will fix the CVE upstream

EDIT
Created #434

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@kubevirt-bot kubevirt-bot merged commit 4827d48 into k8snetworkplumbingwg:main Feb 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants