cluster: Fix kubevirtci clone storm

[oshoval]

What this PR does / why we need it:

cluster::install checks whether the existing kubevirtci clone matches the requested one by comparing both the remote URL and the tag.
The remote URL check fails when the clone was done via SSH (git@github.com:...) because the stored KUBEVIRTCI_REPO uses HTTPS (https://github.com/...).
The mismatch causes kubevirtci to be deleted and re-cloned on every invocation, wiping the cluster kubeconfig and breaking the dev workflow.

Remove the remote URL check and keep only the tag comparison.

Derived from: kubevirt/cluster-network-addons-operator#2619

Special notes for your reviewer:

Release note:

NONE

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oshoval
Once this PR has been reviewed and has the lgtm label, please assign schseba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oshoval]

cc @ormergi

[oshoval]

/test pull-e2e-ovs-cni

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a recurring issue where the kubevirtci cluster environment was being repeatedly reset due to an incorrect repository URL check. By simplifying the check to only compare the repository's tag, the system now avoids unnecessary re-cloning, preserving the cluster's kubeconfig and streamlining the development process.

Highlights

• Resolved 'kubevirtci clone storm': Addressed an issue where the kubevirtci repository was being unnecessarily deleted and re-cloned on every invocation, leading to a 'clone storm' and disruption of development workflows.
• Simplified repository check logic: Removed the remote URL comparison from the cluster::install function, as it was causing false mismatches, especially when kubevirtci was cloned via SSH.
• Retained tag-based comparison: Ensured that kubevirtci is still re-cloned if its tag (version) does not match the requested one, maintaining necessary version control.

Changelog

• cluster/cluster.sh
  • Removed the KUBEVIRTCI_REPO variable.
  • Deleted the cluster::_get_repo function.
  • Modified the cluster::install function to remove the remote URL comparison, retaining only the tag comparison.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[ormergi]

/lgtm

[kubevirt-bot]

@ormergi: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.