chore(deps): update module k8s.io/client-go to v0.20.0 [security] (release-0.31)#448
Conversation
Signed-off-by: redhat-renovate-bot <redhat-internal-renovate@redhat.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-renovate-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@redhat-renovate-bot: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Code Review
This pull request updates k8s.io/client-go to v0.20.0 to address a security vulnerability. While the update is necessary, it introduces a version skew between k8s.io/client-go and other Kubernetes dependencies which are pinned to v0.19.1. This can lead to compatibility issues. My review includes a critical comment suggesting an alternative approach to update all related k8s.io dependencies to a consistent v0.19.x version to mitigate this risk while still fixing the vulnerability.
| k8s.io/apiserver => k8s.io/apiserver v0.19.1 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.19.1 | ||
| k8s.io/client-go => k8s.io/client-go v0.19.1 | ||
| k8s.io/client-go => k8s.io/client-go v0.20.0 |
There was a problem hiding this comment.
Updating k8s.io/client-go to v0.20.0 while keeping other k8s.io dependencies at v0.19.1 introduces a version skew between different minor versions of Kubernetes components. This is not recommended and can lead to subtle bugs and incompatibilities.
To fix the security vulnerability (CVE-2020-8565) while maintaining version consistency, I suggest updating all k8s.io dependencies to a patched version within the v0.19.x series, such as v0.19.16. This aligns with the // Pinned to kubernetes-1.19.1 comment and avoids the risks of mixing major versions.
Suggested change for the whole replace block:
// Pinned to kubernetes-1.19.16
replace (
k8s.io/api => k8s.io/api v0.19.16
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.19.16
k8s.io/apimachinery => k8s.io/apimachinery v0.19.16
k8s.io/apiserver => k8s.io/apiserver v0.19.16
k8s.io/cli-runtime => k8s.io/cli-runtime v0.19.16
k8s.io/client-go => k8s.io/client-go v0.19.16
k8s.io/cloud-provider => k8s.io/cloud-provider v0.19.16
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.19.16
k8s.io/code-generator => k8s.io/code-generator v0.19.16
k8s.io/component-base => k8s.io/component-base v0.19.16
k8s.io/cri-api => k8s.io/cri-api v0.19.16
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.19.16
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.19.16
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.19.16
k8s.io/kube-proxy => k8s.io/kube-proxy v0.19.16
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.19.16
k8s.io/kubectl => k8s.io/kubectl v0.19.16
k8s.io/kubelet => k8s.io/kubelet v0.19.16
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.19.16
k8s.io/metrics => k8s.io/metrics v0.19.16
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.19.16
)
This PR contains the following updates:
v0.19.1->v0.20.0Kubernetes client-go vulnerable to Sensitive Information Leak via Log File
CVE-2020-8565 / GHSA-8cfg-vx93-jvxw / GO-2021-0064
More information
Details
In Kubernetes, if the logging level is set to at least 9, authorization and bearer tokens will be written to log files. This can occur both in API server logs and client tool output like kubectl. This affects <= v1.19.5, <= v1.18.13, <= v1.17.15, < v1.20.0-alpha2.
Severity
CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Unauthorized credential disclosure via debug logs in k8s.io/kubernetes and k8s.io/client-go
CVE-2020-8565 / GHSA-8cfg-vx93-jvxw / GO-2021-0064
More information
Details
Authorization tokens may be inappropriately logged if the verbosity level is set to a debug level. This is due to an incomplete fix for CVE-2019-11250.
Severity
Unknown
References
This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).
Release Notes
kubernetes/client-go (k8s.io/client-go)
v0.20.0Compare Source
v0.19.16Compare Source
v0.19.15Compare Source
v0.19.14Compare Source
v0.19.13Compare Source
v0.19.12Compare Source
v0.19.11Compare Source
v0.19.10Compare Source
v0.19.9Compare Source
v0.19.8Compare Source
v0.19.7Compare Source
v0.19.6Compare Source
v0.19.5Compare Source
v0.19.4Compare Source
v0.19.3Compare Source
v0.19.2Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.