-
Notifications
You must be signed in to change notification settings - Fork 157
bump: update github.com/vishvananda/netlink to latest main pseudo-ver… #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashokpariya0
wants to merge
1
commit into
k8snetworkplumbingwg:master
Choose a base branch
from
ashokpariya0:bump-netlink-pkg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pseudo-version for
github.com/vishvananda/netlinkhas an incorrect timestamp. The year is2026, but the commit0fc897210fbdwas made in2024. This should be corrected to avoid potential dependency resolution issues. The correct version string should bev1.3.2-0.20240310143705-0fc897210fbd. Please update this line and then rungo mod tidyto updatego.sum.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashokpariya0 can you please fix this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to fix here, this suggestion is wrong i think, because this commit was done in 2026 only,
you can see here-https://github.com/vishvananda/netlink/commits/main/
bot mistakenly claimed it was from 2024, which is incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is a gemini's allucination.
The problem is with the e2e tests, which are consistently failing on this PR only.
Looking at the archives, I see:
please take a look at the artifacts in
https://github.com/k8snetworkplumbingwg/sriov-cni/actions/runs/22939939733?pr=404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am checking this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectVFInfo is true by default
https://github.com/vishvananda/netlink/blob/ddba687f44e58e84459de72e6d940abd44ff33f8/handle_linux.go#L152
but we are using zero value struct here at-
sriov-cni/pkg/utils/netlink_manager.go
Line 34 in d8aa2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give a try with after adding this commit to the PR?
63f57b9 -
as pointed out earlier this is not enough, we see below issue too
Warning FailedCreatePodSandBox 8s kubelet Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_testpod-7bw4b_sriov-conformance-testing_c214752f-2478-4431-adac-c78b3aded285_0(f8363a893d1db46350199cdb2a3409a020f961255763e573eeb4b0fd7353a06d): error adding pod sriov-conformance-testing_testpod-7bw4b to CNI network "multus-cni-network": plugin type="multus-shim" name="multus-cni-network" failed (add): CmdAdd (shim): CNI request failed with status 400: 'ContainerID:"f8363a893d1db46350199cdb2a3409a020f961255763e573eeb4b0fd7353a06d" Netns:"/var/run/netns/e45b0d75-1bb9-4d22-9da7-ddff0624ebaf" IfName:"eth0" Args:"IgnoreUnknown=1;K8S_POD_NAMESPACE=sriov-conformance-testing;K8S_POD_NAME=testpod-7bw4b;K8S_POD_INFRA_CONTAINER_ID=f8363a893d1db46350199cdb2a3409a020f961255763e573eeb4b0fd7353a06d;K8S_POD_UID=c214752f-2478-4431-adac-c78b3aded285" Path:"" ERRORED: error configuring pod [sriov-conformance-testing/testpod-7bw4b] networking: [sriov-conformance-testing/testpod-7bw4b/c214752f-2478-4431-adac-c78b3aded285:test-me-network]: error adding container to network "test-me-network": failed to set up pod interface "net1" from the device "ens2048f0np0": setupVF failed: failed to find "ens2048f0v0" in tempNS after retries: Link not found; rollback failed: failed to find interface with any of the possible names: [net1 ens2048f0v0]
': StdinData: {"auxiliaryCNIChainName":"vendor-cni-chain","binDir":"/var/lib/cni/bin","clusterNetwork":"/host/run/multus/cni/net.d/10-ovn-kubernetes.conf","cniVersion":"0.3.1","daemonSocketDir":"/run/multus/socket","globalNamespaces":"default,openshift-multus,openshift-sriov-network-operator,openshift-cnv","logLevel":"verbose","logToStderr":true,"name":"multus-cni-network","namespaceIsolation":true,"type":"multus-shim"}
[root@b3e26~]#
[root@b3e26 ~]#
[root@b3e26 ~]#
[root@b3e26 ~]# oc debug node/master-0.ocp-ashok.lnxero1.boe
Starting pod/master-0ocp-ashoklnxero1boe-debug-g48db ...
To use host binaries, run
chroot /host. Instead, if you need to access host namespaces, runnsenter -a -t 1.Pod IP: 172.23.228.37
All commands and output from this session will be recorded in container logs, including credentials and sensitive information passed through the command prompt.
If you don't see a command prompt, try pressing enter.
sh-5.1# lspci
0000:00:00.0 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function
0001:00:00.0 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function
0002:00:00.0 Ethernet controller: Mellanox Technologies MT2894 Family [ConnectX-6 Lx]
0002:00:00.1 Ethernet controller: Mellanox Technologies MT2894 Family [ConnectX-6 Lx]
0002:00:00.2 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function
0002:00:00.3 Ethernet controller: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function
sh-5.1# ip show link ens2048f0v0
Object "show" is unknown, try "ip help".
sh-5.1# ip link show ens2048f0v0
124: ens2048f0v0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 4e:e1:71:5c:40:7a brd ff:ff:ff:ff:ff:ff
altname enP2p0s0f0v0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once we move ns to temporary ns at:
https://github.com/k8snetworkplumbingwg/sriov-cni/blob/master/pkg/sriov/sriov.go#L101
lookup inside temp ns is failing-
sriov-cni/pkg/sriov/sriov.go
Line 108 in d8aa2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tests and my thought is that we need to fix the library
Using the
netlink.NewHandle()method completely changes the library behavior, as the netlink requests become bound to the namespace where the NewHandle is invoked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion here:
vishvananda/netlink#1173 (comment)
we are waiting for the corresponding changes to be merged in netlink before proceeding. cc @zeeke