Revert "🌱 Making workflows not run on forks."#557
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 9092506522Details
💛 - Coveralls |
Contributor
Contributor
|
@zeeke lets revert, for now, I don't want to block any PRs. |
Contributor
|
/lgtm |
Member
Author
|
@adilGhaffarDev thanks for checking that. @Eoghan1232, @adrianchiris, @SchSeba Please take a look at this revert PR. |
Eoghan1232
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #540
as it breaks the image push actions
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799
Looks like
jobs.<job_id>.ifdoes not have access to theenvcontexthttps://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
cc @adilGhaffarDev , @Eoghan1232 , @SchSeba