restart the device plugin if NotifyRegistrationStatus returns failure#600
Open
liuyuan10 wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Open
restart the device plugin if NotifyRegistrationStatus returns failure#600liuyuan10 wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
liuyuan10 wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 14307870838Details
💛 - Coveralls |
Today it only logs and stop the rpc server. The plugin hangs after that. Signed-off-by: Yuan Liu <liuyuan@google.com>
Contributor
Author
|
@adrianchiris I wonder if you can take a quick look of this PR? it should be a small fix |
Collaborator
|
I re-open to trigger the CI system again @adrianchiris when you have time please take a look on this one |
adrianchiris
reviewed
Apr 7, 2025
| } else { | ||
| glog.Infof("Plugin: %s failed to be registered at Kubelet: %v; restarting.\n", rs.endPoint, regstat.Error) | ||
| rs.grpcServer.Stop() | ||
| glog.Fatalf("Plugin: %s failed to be registered at Kubelet: %v; restarting.\n", rs.endPoint, regstat.Error) |
Contributor
There was a problem hiding this comment.
im not sure im OK with logging a msg then panic,
maybe we need some way to signal errors and exit gracefully ?
what others think of this ?
Collaborator
There was a problem hiding this comment.
sure we can switch to log.err and exit 1 or something like that
Contributor
Author
There was a problem hiding this comment.
isn't log.Fatal the same as log and exit 1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today it only logs and stop the rpc server. The plugin hangs after that.