Skip to content

test: replace curl with wget in exporter metrics conformance test #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashokpariya0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: replace curl with wget in exporter metrics conformance test #1045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/conformance/tests/test_exporter_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func getMetricsForNode(nodeName string) map[string]*dto.MetricFamily {

metricsExporterPod := metricsExporterPods.Items[0]

command := []string{"curl", "http://127.0.0.1:9110/metrics"}
command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}
Copy link

@gemini-code-assist gemini-code-assist bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The metrics URL is hardcoded. To improve readability and maintainability, it's better to define it as a constant. This avoids using a 'magic string' and makes it easier to find and update if needed.

Suggested change
command := []string{"wget", "-qO-", "http://127.0.0.1:9110/metrics"}
const metricsURL = "http://127.0.0.1:9110/metrics"
command := []string{"wget", "-qO-", metricsURL}

stdout, stderr, err := pod.ExecCommand(clients, &metricsExporterPod, command...)
Expect(err).ToNot(HaveOccurred(),
"pod: [%s/%s] command: [%v]\nstdout: %s\nstderr: %s", metricsExporterPod.Namespace, metricsExporterPod.Name, command, stdout, stderr)
Expand Down
Loading