Skip to content

Move systemd to host package #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Move systemd to host package #853

merged 1 commit into from
Mar 7, 2025

Conversation

@SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Feb 25, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 25, 2025

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Feb 25, 2025

waiting for #788 to rebase
/hold

@github-actions github-actions bot added the hold label Feb 25, 2025
@SchSeba SchSeba force-pushed the move_systemd_to_host_package branch 2 times, most recently from c6b86c5 to b883012 Compare February 25, 2025 19:40
@coveralls
Copy link

coveralls commented Feb 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13677347230

Details

  • 142 of 318 (44.65%) changed or added relevant lines in 6 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.5%) to 48.413%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 3 10 30.0%
cmd/sriov-network-config-daemon/service.go 71 85 83.53%
pkg/helper/mock/mock_helper.go 64 85 75.29%
pkg/host/internal/systemd/systemd.go 2 51 3.92%
pkg/host/mock/mock_host.go 0 85 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/config.go 2 93.75%
cmd/sriov-network-config-daemon/service.go 3 75.73%
controllers/helper.go 3 70.23%
controllers/sriovnetworknodepolicy_controller.go 3 58.66%
Totals Coverage Status
Change from base Build 13658529246: -0.5%
Covered Lines: 7352
Relevant Lines: 15186
💛 - Coveralls

@SchSeba SchSeba force-pushed the move_systemd_to_host_package branch 2 times, most recently from 696d64f to e9bf0e6 Compare February 26, 2025 09:16
ykulazhenkov
ykulazhenkov reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR overall looks good. I added few comments.

@SchSeba
Move systemd pakcage under hostInterface
bbc18ec 
this commit also switch the cmd/service to use a struct to not pass
variables all around

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the move_systemd_to_host_package branch from e9bf0e6 to bbc18ec Compare March 5, 2025 13:40
zeeke
zeeke approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit 230f50b into k8snetworkplumbingwg:master Mar 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeeke zeeke zeeke approved these changes

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

Assignees

No one assigned

Labels

hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SchSeba @coveralls @zeeke @ykulazhenkov