Create platform and orchestrator packages #902

SchSeba · 2025-06-11T07:50:09Z

No description provided.

github-actions · 2025-06-11T07:50:17Z

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2025-06-11T08:07:54Z

Pull Request Test Coverage Report for Build 19227470377

Details

319 of 659 (48.41%) changed or added relevant lines in 25 files are covered.
41 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.2%) to 62.151%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/sriovnetworkpoolconfig_controller.go	3	4	75.0%
controllers/sriovoperatorconfig_controller.go	6	7	85.71%
pkg/platform/openstack/helpers.go	0	1	0.0%
pkg/host/internal/udev/udev.go	0	2	0.0%
pkg/orchestrator/openshift/openshift.go	19	21	90.48%
pkg/orchestrator/kubernetes/kubernetes.go	15	18	83.33%
pkg/host/manager.go	0	4	0.0%
pkg/host/mock/mock_host.go	0	4	0.0%
pkg/daemon/plugin.go	12	19	63.16%
pkg/daemon/status.go	9	17	52.94%

Files with Coverage Reduction	New Missed Lines	%
cmd/sriov-network-config-daemon/start.go	1	9.01%
controllers/sriovoperatorconfig_controller.go	1	73.16%
controllers/sriovnetworkpoolconfig_controller.go	2	64.71%
pkg/plugins/k8s/k8s_plugin.go	3	78.85%
pkg/plugins/virtual/virtual_plugin.go	3	80.58%
cmd/sriov-network-config-daemon/service.go	4	74.18%
api/v1/helper.go	5	79.17%
pkg/daemon/plugin.go	7	54.84%
pkg/daemon/daemon.go	15	45.66%

Totals
Change from base Build 19210182850:	-0.2%
Covered Lines:	8772
Relevant Lines:	14114

💛 - Coveralls

zeeke

I left some comments. Overall, thr refactor looks good. I like the we finally started handling the generic plugin as the "main" one.

cmd/sriov-network-config-daemon/service.go

pkg/daemon/plugin.go

pkg/host/internal/sriov/sriov.go

SchSeba · 2025-07-21T11:31:39Z

Hi @adrianchiris @zeeke @e0ne as requested here is the design proposal for this feature #917
please review it when you have the time thanks!

cmd/sriov-network-config-daemon/service.go

This creates an interface for orchestrators both for vanilla kubernetes and openshift

This creates an interface for platform adding baremetal and openstack with a preparation for additional ones Signed-off-by: Sebastian Sch <[email protected]>

pkg/consts/platforms.go

pkg/host/manager.go

pkg/utils/utils.go

pkg/daemon/status.go

pkg/platform/baremetal/baremetal.go

pkg/platforms/openstack/openstack.go

pkg/platform/openstack/openstack.go

adrianchiris · 2025-10-29T17:20:17Z

provided feedback, lets have CI green. once comments addressed im LGTM. great work @SchSeba !

adrianchiris · 2025-10-29T17:21:04Z

once merged, lets sync the changes back to the design doc so it can serve as reference for implementors

SchSeba · 2025-11-03T08:06:20Z

Hi @adrianchiris @zeeke can you give another round review please

zeeke

LGTM!

Thanks for this work

SchSeba · 2025-11-06T07:17:57Z

Hi @adrianchiris as requested I removed the getHostHelpers from the interface.
when you have time please give it another round of review

pkg/platform/openstack/openstack.go

pkg/platform/platform.go

adrianchiris · 2025-11-09T14:26:07Z

@SchSeba please see open discussions. once addressed we can merge IMO

Signed-off-by: Sebastian Sch <[email protected]>

…ders to avoid collision Signed-off-by: Sebastian Sch <[email protected]>

SchSeba · 2025-11-13T12:35:34Z

Thanks! Merging this one

SchSeba force-pushed the create_platform_and_orchestrator_packages branch 2 times, most recently from 9a188ad to 2146e70 Compare June 11, 2025 07:55

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 2146e70 to 838fc5e Compare June 11, 2025 08:22

SchSeba mentioned this pull request Jun 11, 2025

Support aws #899

Open

SchSeba requested review from adrianchiris and zeeke June 11, 2025 17:57

zeeke reviewed Jul 8, 2025

View reviewed changes

cmd/sriov-network-config-daemon/service.go Show resolved Hide resolved

pkg/daemon/plugin.go Outdated Show resolved Hide resolved

pkg/daemon/plugin.go Outdated Show resolved Hide resolved

pkg/host/internal/sriov/sriov.go Outdated Show resolved Hide resolved

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 838fc5e to 23a8e6f Compare July 21, 2025 09:58

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 23a8e6f to 32f7fe1 Compare July 31, 2025 11:44

zeeke reviewed Aug 29, 2025

View reviewed changes

cmd/sriov-network-config-daemon/service.go Outdated Show resolved Hide resolved

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 32f7fe1 to 2ef63a9 Compare September 25, 2025 09:02

SchSeba added 2 commits October 29, 2025 11:13

Create an orchestrator package

7ad0b25

This creates an interface for orchestrators both for vanilla kubernetes and openshift

Create a platform package

b7e600a

This creates an interface for platform adding baremetal and openstack with a preparation for additional ones Signed-off-by: Sebastian Sch <[email protected]>

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 2ef63a9 to b7e600a Compare October 29, 2025 09:13

github-actions bot added the tests label Oct 29, 2025

adrianchiris reviewed Oct 29, 2025

View reviewed changes

SchSeba force-pushed the create_platform_and_orchestrator_packages branch 7 times, most recently from 567b959 to 222674b Compare November 2, 2025 21:25

zeeke approved these changes Nov 3, 2025

View reviewed changes

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from 222674b to afc9f6b Compare November 6, 2025 07:14

adrianchiris reviewed Nov 9, 2025

View reviewed changes

pkg/platform/openstack/openstack.go Outdated Show resolved Hide resolved

adrianchiris reviewed Nov 9, 2025

View reviewed changes

pkg/platform/platform.go Outdated Show resolved Hide resolved

SchSeba added 2 commits November 10, 2025 11:48

Fix review comments

22eba41

Signed-off-by: Sebastian Sch <[email protected]>

go test runs packages in parallel (default) so lets use different fol…

f9637c1

…ders to avoid collision Signed-off-by: Sebastian Sch <[email protected]>

SchSeba force-pushed the create_platform_and_orchestrator_packages branch from afc9f6b to f9637c1 Compare November 10, 2025 09:48

adrianchiris approved these changes Nov 13, 2025

View reviewed changes

SchSeba merged commit 4c5f5af into k8snetworkplumbingwg:master Nov 13, 2025
13 of 14 checks passed

Create platform and orchestrator packages #902

Create platform and orchestrator packages #902

Uh oh!

Conversation

SchSeba commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

coveralls commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19227470377

Details

💛 - Coveralls

Uh oh!

zeeke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SchSeba commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adrianchiris commented Oct 29, 2025

Uh oh!

adrianchiris commented Oct 29, 2025

Uh oh!

SchSeba commented Nov 3, 2025

Uh oh!

zeeke left a comment

Choose a reason for hiding this comment

Uh oh!

SchSeba commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

adrianchiris commented Nov 9, 2025

Uh oh!

SchSeba commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jun 11, 2025 •

edited

Loading