Host name determination from k8s api #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13444567631Details
💛 - Coveralls |
Collaborator
Author
|
ran e2e locally and all 27 of them passed @dougbtv |
thomasferrandiz
approved these changes
Feb 20, 2025
dougbtv
reviewed
Feb 20, 2025
pkg/storage/kubernetes/ipam.go
Outdated
| return normalizedIP | ||
| } | ||
|
|
||
| // TODO: what's the best way to discover the node name? this should work in both controller pod and whereabouts host process |
Member
There was a problem hiding this comment.
Let's update this line with:
getNodeName prefers an OS env var of NODENAME, or, uses a file named ./nodename in the whereabouts configuration path.
dougbtv
requested changes
Feb 20, 2025
Member
dougbtv
left a comment
dougbtv
left a comment
There was a problem hiding this comment.
just some nits to clean up, thanks for this one Ben
pkg/storage/kubernetes/ipam.go
Outdated
| return "", err | ||
| file, err = os.Open("/etc/hostname") | ||
| if err != nil { | ||
| logging.Errorf("Error opening nodeNameFile, defaulted to /etc/hostname: %v", err) |
Member
There was a problem hiding this comment.
let's change this to:
logging.Errorf("Could not determine nodename and could not open /etc/hostname: %v", err)
AWS and GCP host name on /etc/host differs so we need to standardize the way we resolve the node name on the host Contributer: @dougbtv the goat Signed-off-by: Benjamin Pickard <[email protected]>
bpickard22
force-pushed
the
hostname-standard
branch
from
36f4ecf to
a443e51
Compare
Member
|
e2e test is flaking in the same spots. it's unrelated. thanks Ben, appreciate you spiffing it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host name in /etc/host can differ from the nodename in the k8s API, so we standardize the way we calculate the hostname -- always from the K8s API, and then write it to a file on the host so that the CNI plugin side can always read it.
Contributer: @dougbtv the goat